Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 8418028: Destroy tooltip manager if the native window is destroyed. (Closed)

Created:
9 years, 1 month ago by varunjain
Modified:
9 years, 1 month ago
Reviewers:
oshima, sky
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Destroy tooltip manager if the native window is destroyed. Also revert the previous attempt to fix this issue: Revert "Aura build fix: Make TooltipManagerViews an observer of parent Widget and" This reverts commit 6749813691870c8311c81c030bee9e1d4ad305ff. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107776

Patch Set 1 #

Total comments: 4

Patch Set 2 : modified according to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M views/widget/native_widget_aura.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M views/widget/tooltip_manager_views.h View 3 chunks +1 line, -8 lines 0 comments Download
M views/widget/tooltip_manager_views.cc View 4 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
varunjain
9 years, 1 month ago (2011-10-28 18:00:37 UTC) #1
sky
LGTM http://codereview.chromium.org/8418028/diff/1/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8418028/diff/1/views/widget/native_widget_aura.cc#newcode539 views/widget/native_widget_aura.cc:539: // If the aura::Window is destryoed, we can ...
9 years, 1 month ago (2011-10-28 18:26:33 UTC) #2
varunjain
http://codereview.chromium.org/8418028/diff/1/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8418028/diff/1/views/widget/native_widget_aura.cc#newcode539 views/widget/native_widget_aura.cc:539: // If the aura::Window is destryoed, we can no ...
9 years, 1 month ago (2011-10-28 18:35:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/8418028/1004
9 years, 1 month ago (2011-10-28 18:35:43 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 19:56:46 UTC) #5
Change committed as 107776

Powered by Google App Engine
This is Rietveld 408576698