Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8418021: Proper fix for failing FileManagerDialogBrowserTest.* (Closed)

Created:
9 years, 1 month ago by Vladislav Kaznacheev
Modified:
9 years, 1 month ago
Reviewers:
Oleg Eterevsky
CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Proper fix for failing FileManagerDialogBrowserTest.* BUG=chromium-os:22174 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata_dispatcher.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review this small patch
9 years, 1 month ago (2011-10-28 12:58:48 UTC) #1
Oleg Eterevsky
lgtm
9 years, 1 month ago (2011-10-28 13:00:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8418021/1
9 years, 1 month ago (2011-10-28 13:00:51 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 14:45:07 UTC) #4
Change committed as 107729

Powered by Google App Engine
This is Rietveld 408576698