Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 8418019: Suppress memcheck leaks and update a TSAN rule. (Closed)

Created:
9 years, 1 month ago by Hironori Bono
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Suppress memcheck leaks and update a TSAN rule. This change suppresses leaks in the SkCanvas code in the PrintPreviewUITest.LoadPrintPreviewByURL and updates a rule that is not updated by r107697 <http://crrev.com/107697>;. TBR=timurrrr,glider,thestig BUG=102049, 93932 TEST=make memcheck bots and TSAN bots green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
9 years, 1 month ago (2011-10-28 10:51:56 UTC) #1
Timur Iskhodzhanov
9 years, 1 month ago (2011-10-28 12:10:36 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698