Miscellaneous header file cleanup for src/media.

Miscellaneous header file cleanup for src/media.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107772

[scherkus (not reviewing), 2011-10-28 16:43:07]

attempting a little IWYU

[scherkus (not reviewing), 2011-10-28 16:45:02]

http://codereview.chromium.org/8418017/diff/1/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

http://codereview.chromium.org/8418017/diff/1/media/filters/chunk_demuxer.h#n...
media/filters/chunk_demuxer.h:11: #include "media/base/audio_decoder_config.h"
hmmm... these are only used in .cc

http://codereview.chromium.org/8418017/diff/1/media/filters/ffmpeg_video_deco...
File media/filters/ffmpeg_video_decoder.h (right):

http://codereview.chromium.org/8418017/diff/1/media/filters/ffmpeg_video_deco...
media/filters/ffmpeg_video_decoder.h:13: 
there should be one here for ui/gfx/size.h

[Ami GONE FROM CHROMIUM, 2011-10-28 16:54:22]

LGTM but FWIW I'm not sure how worthwhile manual IWYU is, since it'll very
quickly get out of date.

http://codereview.chromium.org/8418017/diff/1/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

http://codereview.chromium.org/8418017/diff/1/media/filters/chunk_demuxer.h#n...
media/filters/chunk_demuxer.h:11: #include "media/base/audio_decoder_config.h"
On 2011/10/28 16:45:02, scherkus wrote:
> hmmm... these are only used in .cc

So why not move them there?

http://codereview.chromium.org/8418017/diff/1/media/filters/ffmpeg_video_deco...
File media/filters/ffmpeg_video_decoder.h (right):

http://codereview.chromium.org/8418017/diff/1/media/filters/ffmpeg_video_deco...
media/filters/ffmpeg_video_decoder.h:13: 
On 2011/10/28 16:45:02, scherkus wrote:
> there should be one here for ui/gfx/size.h

So why not add it?

[scherkus (not reviewing), 2011-10-28 16:57:39]

Only noticed those things post-review-send-out :)

these IWYU-isms were the result from doing refactoring work in other CLs but
wanted to cleave these off first

[commit-bot: I haz the power, 2011-10-28 17:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/8418017/4002

[commit-bot: I haz the power, 2011-10-28 17:42:41]

Try job failure for 8418017-4002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-10-28 18:13:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/8418017/4004

[commit-bot: I haz the power, 2011-10-28 19:36:48]

Change committed as 107772