Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 8417045: Last small bit of refactoring. (Closed)

Created:
9 years, 1 month ago by dgarrett
Modified:
9 years, 1 month ago
Reviewers:
sra, sra1
CC:
chromium-reviews, Michael Krebs, adlr
Visibility:
Public.

Description

Last small bit of refactoring. Move the Win32X86Generator and Patcher classes to non-windows specific names since they can be reused untouched for Elf. Move them from one file to files with matching names while at it. Store the transformation kind on the generator class so that it can be know if it's PE or Elf. Unified the TransformationId and ExecutableType enums into a single enum used everywhere (defined in courgette.h since it's now part of the external API). BUG=chromium-os:22149 TEST=Unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -264 lines) Patch
M courgette/courgette.h View 1 chunk +3 lines, -3 lines 0 comments Download
M courgette/courgette.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M courgette/disassembler.h View 1 chunk +1 line, -1 line 0 comments Download
M courgette/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/disassembler_win32_x86.h View 1 chunk +1 line, -1 line 0 comments Download
M courgette/ensemble.h View 2 chunks +1 line, -7 lines 0 comments Download
M courgette/ensemble_apply.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M courgette/ensemble_create.cc View 3 chunks +8 lines, -7 lines 0 comments Download
A + courgette/patch_generator_x86_32.h View 2 chunks +11 lines, -9 lines 0 comments Download
A + courgette/patcher_x86_32.h View 2 chunks +4 lines, -4 lines 0 comments Download
D courgette/win32_x86_generator.h View 1 chunk +0 lines, -133 lines 0 comments Download
D courgette/win32_x86_patcher.h View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgarrett
9 years, 1 month ago (2011-10-29 01:14:43 UTC) #1
sra1
lgtm
9 years, 1 month ago (2011-10-31 06:28:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8417045/1
9 years, 1 month ago (2011-10-31 21:02:37 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 22:09:41 UTC) #4
Change committed as 108019

Powered by Google App Engine
This is Rietveld 408576698