Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: chrome/browser/webdata/web_intents_table.h

Issue 8417043: Add webkit_glue namespace. Improve some variable and test names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_intents_table.h
diff --git a/chrome/browser/webdata/web_intents_table.h b/chrome/browser/webdata/web_intents_table.h
index a54293090b6178ee6b85739a36ee6210c303dae8..e85999bb94fb36e30095bf5687afc66e89c008dd 100644
--- a/chrome/browser/webdata/web_intents_table.h
+++ b/chrome/browser/webdata/web_intents_table.h
@@ -38,19 +38,20 @@ class WebIntentsTable : public WebDatabaseTable {
virtual bool Init();
virtual bool IsSyncable();
- // Adds a web intent to the WebIntents table. If intent already exists,
- // replaces it.
- bool SetWebIntent(const WebIntentServiceData& intent);
+ // Adds a web intent service to the WebIntents table.
+ // If service already exists, replaces it.
groby-ooo-7-16 2011/10/31 20:53:37 nit: |service| - here and elsewhere
Greg Billock 2011/11/01 17:11:17 Done.
+ bool SetWebIntent(const webkit_glue::WebIntentServiceData& service);
- // Retrieve all intents from WebIntents table that match |action|.
+ // Retrieve all services from WebIntents table that match |action|.
groby-ooo-7-16 2011/10/31 20:53:37 nit: |services| - here and elsewhere
Greg Billock 2011/11/01 17:11:17 Done.
bool GetWebIntents(const string16& action,
- std::vector<WebIntentServiceData>* intents);
+ std::vector<webkit_glue::WebIntentServiceData>* services);
- // Retrieve all intents from WebIntents table.
- bool GetAllWebIntents(std::vector<WebIntentServiceData>* intents);
+ // Retrieve all services from WebIntents table.
+ bool GetAllWebIntents(
+ std::vector<webkit_glue::WebIntentServiceData>* services);
- // Removes intent from WebIntents table - must match all parameters exactly.
- bool RemoveWebIntent(const WebIntentServiceData& intent);
+ // Removes service from WebIntents table - must match all parameters exactly.
+ bool RemoveWebIntent(const webkit_glue::WebIntentServiceData& service);
private:
DISALLOW_COPY_AND_ASSIGN(WebIntentsTable);

Powered by Google App Engine
This is Rietveld 408576698