net: add missing return value in SSL_SetNextProtoCallback

net/third_party/nss/ssl/sslsock.c

 /*
  * vtables (and methods that call through them) for the 4 types of 
  * SSLSockets supported.  Only one type is still supported.
  * Various other functions.
  *
  * ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
@@ skipping 1301 matching lines @@
 
 SECStatus
 SSL_SetNextProtoCallback(PRFileDesc *fd,
                          SSLNextProtoCallback callback,
                          void *arg) {
     sslSocket *ss = ssl_FindSocket(fd);
 
     if (!ss) {
         SSL_DBG(("%d: SSL[%d]: bad socket in SSL_SetNextProtoNego", SSL_GETPID(),
                 fd));
+        PORT_SetError(SEC_ERROR_INVALID_ARGS);
         return SECFailure;
     }
 
     ssl_GetSSL3HandshakeLock(ss);
     ss->nextProtoCallback = callback;
     ss->nextProtoArg = arg;
     ssl_ReleaseSSL3HandshakeLock(ss);
+    return SECSuccess;
 }
 
 /* NextProtoStandardCallback is set as an NPN callback for the case when the
  * user of the sockets wants the standard selection algorithm. */
 static SECStatus
 NextProtoStandardCallback(void *arg,
                           PRFileDesc *fd,
                           const unsigned char *protos,
                           unsigned int protos_len,
                           unsigned char *protoOut,
@@ skipping 41 matching lines @@
 SSL_SetNextProtoNego(PRFileDesc *fd, const unsigned char *data,
                      unsigned int length)
 {
     SECStatus rv;
 
     sslSocket *ss = ssl_FindSocket(fd);
 
     if (!ss) {
         SSL_DBG(("%d: SSL[%d]: bad socket in SSL_SetNextProtoNego",
                  SSL_GETPID(), fd));
+        PORT_SetError(SEC_ERROR_INVALID_ARGS);
         return SECFailure;
     }
 
     if (ssl3_ValidateNextProtoNego(data, length) != SECSuccess)
         return SECFailure;
 
     ssl_GetSSL3HandshakeLock(ss);
     if (ss->opt.nextProtoNego.data)
         PORT_Free(ss->opt.nextProtoNego.data);
     ss->opt.nextProtoNego.data = PORT_Alloc(length);
@@ skipping 1217 matching lines @@
 loser:
             ssl_DestroySocketContents(ss);
             ssl_DestroyLocks(ss);
             PORT_Free(ss);
             ss = NULL;
         }
     }
     return ss;
 }