Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 8417029: Make settings page more touch friendly (font-size, checkbox, radio, adding language page). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Remove unnecessary double quote. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_options.js
diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js
index 06b2fec66aba3e146bdedc57de6d81f7a1b1a3ce..191202972c28e05bd84b8aca1176bde1f98659c6 100644
--- a/chrome/browser/resources/options/language_options.js
+++ b/chrome/browser/resources/options/language_options.js
@@ -77,30 +77,30 @@ cr.define('options', function() {
}
};
- if (cr.isChromeOS) {
+ if (cr.isChromeOS && !cr.isTouch) {
// Listen to user clicks on the add language list.
var addLanguageList = $('add-language-overlay-language-list');
addLanguageList.addEventListener('click',
this.handleAddLanguageListClick_.bind(this));
+ } else {
+ // Listen to add language dialog ok button.
+ var addLanguageOkButton = $('add-language-overlay-ok-button');
+ addLanguageOkButton.addEventListener('click',
+ this.handleAddLanguageOkButtonClick_.bind(this));
+
// Listen to user clicks on the "Change touch keyboard settings..."
// button.
- if (cr.isTouch) {
+ if (cr.isChromeOS && cr.isTouch) {
var virtualKeyboardButton = $('language-options-virtual-keyboard');
// TODO(yusukes): would be better to hide the button if no virtual
// keyboard is registered.
virtualKeyboardButton.onclick = function(e) {
OptionsPage.navigateToPage('virtualKeyboards');
};
- }
- } else {
- // Listen to add language dialog ok button.
- var addLanguageOkButton = $('add-language-overlay-ok-button');
- addLanguageOkButton.addEventListener('click',
- this.handleAddLanguageOkButtonClick_.bind(this));
-
- // Show experimental features if enabled.
- if (templateData.experimentalSpellCheckFeatures == 'true') {
- $('auto-spell-correction-option').hidden = false;
+ } else {
+ // Show experimental features if enabled.
+ if (templateData.experimentalSpellCheckFeatures == 'true')
+ $('auto-spell-correction-option').hidden = false;
}
}
« no previous file with comments | « chrome/browser/resources/options/language_options.css ('k') | chrome/browser/resources/options/options_page.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698