aura: Update how the tooltip manager works.

views/widget/tooltip_manager_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/tooltip_manager_views.h"
 
 #if defined(USE_X11)
 #include <X11/Xlib.h>
 #include <X11/extensions/XInput2.h>
 #endif
@@ skipping 64 matching lines @@
 
 TooltipManagerViews::TooltipManagerViews(views::View* root_view)
     : root_view_(root_view),
       tooltip_view_(NULL) {
   tooltip_label_.set_background(
       views::Background::CreateSolidBackground(kTooltipBackground));
   tooltip_widget_.reset(CreateTooltip());
   tooltip_widget_->SetContentsView(&tooltip_label_);
   tooltip_widget_->Activate();
   tooltip_widget_->SetAlwaysOnTop(true);
-  tooltip_timer_.Start(FROM_HERE,
-      base::TimeDelta::FromMilliseconds(kTooltipTimeoutMs),
-      this, &TooltipManagerViews::TooltipTimerFired);
-  MessageLoopForUI::current()->AddObserver(this);
 }
 
 TooltipManagerViews::~TooltipManagerViews() {
-  MessageLoopForUI::current()->RemoveObserver(this);
   tooltip_widget_->CloseNow();
 }
 
+void TooltipManagerViews::UpdateForMouseEvent(const MouseEvent& event) {
+  if (event.type() == ui::ET_MOUSE_EXITED) {

[sky, 2011/10/28 17:47:27]

nit: use a switch statement.

[sadrul, 2011/10/28 21:42:52]

Done.

+    // Mouse is exiting this widget. Stop showing the tooltip and the timer.
+    if (tooltip_timer_.IsRunning())
+      tooltip_timer_.Stop();
+    if (tooltip_widget_->IsVisible())
+      tooltip_widget_->Hide();
+  } else if (event.type() == ui::ET_MOUSE_ENTERED) {
+    // Mouse just entered this widget. Start the timer to show the tooltip.
+    CHECK(!tooltip_timer_.IsRunning());
+    tooltip_timer_.Start(FROM_HERE,
+        base::TimeDelta::FromMilliseconds(kTooltipTimeoutMs),
+        this, &TooltipManagerViews::TooltipTimerFired);
+  } else if (event.type() == ui::ET_MOUSE_MOVED) {
+    OnMouseMoved(event.location().x(), event.location().y());
+  } else {
+    // Hide the tooltip for click, release, wheel events.
+    if (tooltip_widget_->IsVisible())
+      tooltip_widget_->Hide();
+  }
+}
+
 void TooltipManagerViews::UpdateTooltip() {
   UpdateIfRequired(curr_mouse_pos_.x(), curr_mouse_pos_.y(), false);
 }
 
 void TooltipManagerViews::TooltipTextChanged(View* view) {
   if (tooltip_widget_->IsVisible())
     UpdateIfRequired(curr_mouse_pos_.x(), curr_mouse_pos_.y(), false);
 }
 
 void TooltipManagerViews::ShowKeyboardTooltip(View* view) {
   NOTREACHED();
 }
 
 void TooltipManagerViews::HideKeyboardTooltip() {
   NOTREACHED();
 }
 
-#if defined(USE_WAYLAND)
-base::MessagePumpObserver::EventStatus TooltipManagerViews::WillProcessEvent(
-      ui::WaylandEvent* event) {
-  if (event->type == ui::WAYLAND_MOTION)
-    OnMouseMoved(event->motion.x, event->motion.y);
-  return base::MessagePumpObserver::EVENT_CONTINUE;
-}
-#elif defined(USE_X11)
-base::EventStatus TooltipManagerViews::WillProcessEvent(
-    const base::NativeEvent& native_event) {
-  if (!ui::IsMouseEvent(native_event))
-    return base::EVENT_CONTINUE;
-#if defined(USE_AURA)
-  aura::MouseEvent event(native_event);
-#else
-  MouseEvent event(native_event);
-#endif
-  switch (event.type()) {
-    case ui::ET_MOUSE_MOVED:
-      OnMouseMoved(event.x(), event.y());
-    default:
-      break;
-  }
-  return base::EVENT_CONTINUE;
-}
-
-void TooltipManagerViews::DidProcessEvent(const base::NativeEvent& event) {
-}
-#elif defined(OS_WIN)
-base::EventStatus TooltipManagerViews::WillProcessEvent(
-    const base::NativeEvent& event) {
-  if (event.message == WM_MOUSEMOVE)
-    OnMouseMoved(GET_X_LPARAM(event.lParam), GET_Y_LPARAM(event.lParam));
-  return base::EVENT_CONTINUE;
-}
-
-void TooltipManagerViews::DidProcessEvent(const base::NativeEvent& event) {
-}
-#endif
-
 void TooltipManagerViews::TooltipTimerFired() {
   UpdateIfRequired(curr_mouse_pos_.x(), curr_mouse_pos_.y(), false);
 }
 
 View* TooltipManagerViews::GetViewForTooltip(int x, int y, bool for_keyboard) {
   View* view = NULL;
   if (!for_keyboard) {
     // Convert x,y from screen coordinates to |root_view_| coordinates.
     gfx::Point point(x, y);
-    gfx::Rect r = root_view_->GetWidget()->GetClientAreaScreenBounds();
-    point.SetPoint(point.x() - r.x(), point.y() - r.y());
     View::ConvertPointFromWidget(root_view_, &point);
     view = root_view_->GetEventHandlerForPoint(point);
   } else {
     FocusManager* focus_manager = root_view_->GetFocusManager();
     if (focus_manager)
       view = focus_manager->GetFocusedView();
   }
   return view;
 }
 
@@ skipping 73 matching lines @@
   if (tooltip_timer_.IsRunning())
     tooltip_timer_.Reset();
   curr_mouse_pos_.SetPoint(x, y);
 
   // If tooltip is visible, we may want to hide it. If it is not, we are ok.
   if (tooltip_widget_->IsVisible())
     UpdateIfRequired(curr_mouse_pos_.x(), curr_mouse_pos_.y(), false);
 }
 
 }  // namespace views