Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5595)

Unified Diff: chrome/chrome_browser.gypi

Issue 8417017: Separate some generated files into their own targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_common.gypi » ('j') | webkit/glue/webkit_glue.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index d29cee5ff04104d1996e250739f9c578c1d47fa7..a21d8ad66da0c072ca3bb9d69a29283d8d99a3bf 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -9,6 +9,7 @@
'type': 'static_library',
'dependencies': [
'app/policy/cloud_policy_codegen.gyp:policy',
+ 'autofill_regexes',
'browser/sync/protocol/sync_proto.gyp:sync_proto',
'cert_logger_proto',
'chrome_extra_resources',
@@ -4010,21 +4011,8 @@
'<(grit_out_dir)/grit/theme_resources_standard_map.cc',
# This file is generated by the autofill_regexes action.
- '<(INTERMEDIATE_DIR)/autofill_regex_constants.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/autofill_regex_constants.cc',
Ryan Sleevi 2011/11/03 07:55:18 drive by: It's considered bad form to drop files d
],
- 'actions': [{
- 'action_name': 'autofill_regexes',
- 'inputs': [
- '<(DEPTH)/build/escape_unicode.py',
- 'browser/autofill/autofill_regex_constants.cc.utf8',
- ],
- 'outputs': [
- '<(INTERMEDIATE_DIR)/autofill_regex_constants.cc',
- ],
- 'action': ['python', '<(DEPTH)/build/escape_unicode.py',
- '-o', '<(INTERMEDIATE_DIR)',
- 'browser/autofill/autofill_regex_constants.cc.utf8'],
- }],
'conditions': [
['debug_devtools==1', {
'defines': [
@@ -5202,6 +5190,23 @@
],
},
{
+ 'target_name': 'autofill_regexes',
+ 'type': 'none',
+ 'actions': [{
+ 'action_name': 'autofill_regexes',
+ 'inputs': [
+ '<(DEPTH)/build/escape_unicode.py',
+ 'browser/autofill/autofill_regex_constants.cc.utf8',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/autofill_regex_constants.cc',
+ ],
+ 'action': ['python', '<(DEPTH)/build/escape_unicode.py',
+ '-o', '<(SHARED_INTERMEDIATE_DIR)',
+ 'browser/autofill/autofill_regex_constants.cc.utf8'],
+ }],
+ },
+ {
# Protobuf compiler / generator for the fraudulent certificate reporting
# protocol buffer.
'target_name': 'cert_logger_proto',
« no previous file with comments | « no previous file | chrome/chrome_common.gypi » ('j') | webkit/glue/webkit_glue.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698