Issue 8417015: Fix a flaky GViewRequestInterceptorTest by refreshing the plugins list before every test case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8417015: Fix a flaky GViewRequestInterceptorTest by refreshing the plugins list before every test case. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
Scott Byer

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a flaky GViewRequestInterceptorTest by refreshing the plugins list before every test case. BUG=none TEST=unit_tests --gtest_filter=GViewRequestInterceptorTest.* and unit_tests --gtest_filter=GViewRequestInterceptorTest.InterceptPdfWithNoPlugins should both pass; Official CrOS bot goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107773

Patch Set 1 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/gview_request_interceptor_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8417015/2001

9 years, 1 month ago (2011-10-28 05:58:42 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-10-28 06:49:00 UTC) #4

Try job failure for 8417015-2001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages