Replace NewRunnable with Callback in DownloadManager.

Replace NewRunnable with Callback in DownloadManager.

BUG=chromium-os:22024
TEST=compiles, tests pass.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107802

[achuithb, 2011-10-27 23:22:40]

Please review

[Randy Smith (Not in Mondays), 2011-10-28 17:37:53]

One change requested.

http://codereview.chromium.org/8417009/diff/1/content/browser/download/downlo...
File content/browser/download/download_manager.cc (right):

http://codereview.chromium.org/8417009/diff/1/content/browser/download/downlo...
content/browser/download/download_manager.cc:46: const
content::ResourceContext*> BeginDownloadParams;
This is very sledgehammery, and the fact that we're accessing it with
params.a/b/c/d/e/f/g tends to reinforce that.  Could you possibly instead create
new structures to get us down below the limit that have some limited conceptual
integrity?  E.g. Combine the url and referred, and combine the render_process_id
and render_view_id?

[achuithb, 2011-10-28 19:51:05]

PTAL Randy.

http://codereview.chromium.org/8417009/diff/1/content/browser/download/downlo...
File content/browser/download/download_manager.cc (right):

http://codereview.chromium.org/8417009/diff/1/content/browser/download/downlo...
content/browser/download/download_manager.cc:46: const
content::ResourceContext*> BeginDownloadParams;
On 2011/10/28 17:37:53, rdsmith wrote:
> This is very sledgehammery, and the fact that we're accessing it with
> params.a/b/c/d/e/f/g tends to reinforce that.  Could you possibly instead
create
> new structures to get us down below the limit that have some limited
conceptual
> integrity?  E.g. Combine the url and referred, and combine the
render_process_id
> and render_view_id?

Done.

[Randy Smith (Not in Mondays), 2011-10-28 20:54:16]

LGTM.