aura: Add fullscreen/popups to RenderWidgetHostViewAura.

ui/aura/desktop_host_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/desktop_host.h"
 
 #include <X11/cursorfont.h>
 #include <X11/Xlib.h>
 
 // Get rid of a macro from Xlib.h that conflicts with Aura's RootWindow class.
 #undef RootWindow
 
 #include <algorithm>
 
 #include "base/message_loop.h"
 #include "base/message_pump_x.h"
 #include "ui/aura/cursor.h"
 #include "ui/aura/desktop.h"
 #include "ui/aura/event.h"
+#include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/touch/touch_factory.h"
 #include "ui/base/x/x11_util.h"
 #include "ui/gfx/compositor/layer.h"
 
 #include <X11/cursorfont.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xlib.h>
 
 using std::max;
 using std::min;
@@ skipping 143 matching lines @@
       } else {
         // This isn't an event we want so free its cookie data.
         XFreeEventData(display, &next_event.xcookie);
       }
     }
     break;
   }
   return num_coalesed;
 }
 
+// We emulate Windows' WM_KEYDOWN and WM_CHAR messages.  WM_CHAR events are only
+// generated for certain keys; see
+// http://msdn.microsoft.com/en-us/library/windows/desktop/ms646268(v=vs.85).aspx
+bool ShouldSendCharEventForKeyboardCode(ui::KeyboardCode keycode) {

[Hironori Bono, 2011/10/28 05:10:12]

nit: we also need true when we type graphic-character keys or numpad keys (i.e.
VKEY_OEM_1,...,VKEY_OEM_7, VKEY_OEM_COMMA, VKEY_OEM_PERIOD, VKEY_OEM_PLUS,
VKEY_OEM_MINUS, VKEY_NUMPAD_0,...,VKEY_NUMPAD_9, VKEY_MULTIPLY, VKEY_ADD,
VKEY_SUBTRACT, VKEY_DECIMAL, VKEY_DIVIDE, etc.)?

+  return (keycode >= ui::VKEY_0 && keycode <= ui::VKEY_9) ||
+         (keycode >= ui::VKEY_A && keycode <= ui::VKEY_Z) ||
+         keycode == ui::VKEY_BACK ||
+         keycode == ui::VKEY_RETURN ||
+         keycode == ui::VKEY_ESCAPE ||
+         // TODO: SHIFT+ENTER (linefeed)?
+         keycode == ui::VKEY_TAB;
+}
+
 class DesktopHostLinux : public DesktopHost {
  public:
   explicit DesktopHostLinux(const gfx::Rect& bounds);
   virtual ~DesktopHostLinux();
 
  private:
   // base::MessageLoop::Dispatcher Override.
   virtual DispatchStatus Dispatch(XEvent* xev) OVERRIDE;
 
   // DesktopHost Overrides.
@@ skipping 56 matching lines @@
     XEvent* xev) {
   bool handled = false;
   switch (xev->type) {
     case Expose:
       desktop_->Draw();
       handled = true;
       break;
     case KeyPress: {
       KeyEvent keydown_event(xev, false);
       handled = desktop_->DispatchKeyEvent(&keydown_event);
-      KeyEvent char_event(xev, true);
-      handled |= desktop_->DispatchKeyEvent(&char_event);
+      if (ShouldSendCharEventForKeyboardCode(keydown_event.key_code())) {
+        KeyEvent char_event(xev, true);
+        handled |= desktop_->DispatchKeyEvent(&char_event);
+      }
       break;
     }
     case KeyRelease: {
       KeyEvent keyup_event(xev, false);
       handled = desktop_->DispatchKeyEvent(&keyup_event);
       break;
     }
     case ButtonPress:
     case ButtonRelease: {
       MouseEvent mouseev(xev);
@@ skipping 169 matching lines @@
   return new DesktopHostLinux(bounds);
 }
 
 // static
 gfx::Size DesktopHost::GetNativeDisplaySize() {
   ::Display* xdisplay = base::MessagePumpX::GetDefaultXDisplay();
   return gfx::Size(DisplayWidth(xdisplay, 0), DisplayHeight(xdisplay, 0));
 }
 
 }  // namespace aura