Issue 8417001: Enforce that chrome/common doesn't depend on content/common through DEPS. Also add a comment in t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8417001: Enforce that chrome/common doesn't depend on content/common through DEPS. Also add a comment in t... (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enforce that chrome/common doesn't depend on content/common through DEPS. Also add a comment in the public dir of content. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107614

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/common/DEPS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	content/public/OWNERS	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

lgtm http://codereview.chromium.org/8417001/diff/1/content/public/OWNERS File content/public/OWNERS (right): http://codereview.chromium.org/8417001/diff/1/content/public/OWNERS#newcode4 content/public/OWNERS:4: # https://sites.google.com/a/chromium.org/dev/developers/content-module/content-api?pli=1 ), I prefer the dev.chromium.org version ...

9 years, 1 month ago (2011-10-27 17:45:42 UTC) #2

jam

9 years, 1 month ago (2011-10-27 20:06:59 UTC) #3

http://codereview.chromium.org/8417001/diff/1/content/public/OWNERS
File content/public/OWNERS (right):

http://codereview.chromium.org/8417001/diff/1/content/public/OWNERS#newcode4
content/public/OWNERS:4: #
https://sites.google.com/a/chromium.org/dev/developers/content-module/content...
),
ah, didn't know about that, done

On 2011/10/27 17:45:42, Avi wrote:
> I prefer the http://dev.chromium.org version of these URLs:
> http://dev.chromium.org/developers/content-module/content-api

Expand Messages | Collapse Messages