Issue 8416053: Gets Bubble to work on aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416053: Gets Bubble to work on aura. (Closed)

Created:
9 years, 1 month ago by sky

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gets Bubble to work on aura. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108029

Patch Set 2 : Make Layer::SetOpacity do ScheduleDraw #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -31 lines)			Patch
M	chrome/browser/ui/views/bubble/bubble.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/bubble/bubble.cc	View		7 chunks	+11 lines, -26 lines	0 comments	Download
M	ui/gfx/compositor/layer.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/8416053/diff/1/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8416053/diff/1/views/widget/native_widget_aura.cc#newcode391 views/widget/native_widget_aura.cc:391: window_->layer()->ScheduleDraw(); Shouldn't Layer::SetOpacity do this implicitly?

9 years, 1 month ago (2011-10-31 18:21:29 UTC) #2

sky

9 years, 1 month ago (2011-10-31 20:32:31 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 8416053: Gets Bubble to work on aura. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make Layer::SetOpacity do ScheduleDraw #

Messages