Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 8416047: Revert 107748 - Add policy for blocking GCP printing. (Closed)

Created:
9 years, 1 month ago by Albert Bodenhamer
Modified:
9 years, 1 month ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 107748 - Add policy for blocking GCP printing. BUG=101389 TEST=On any platform use the appropriate policy mechanism to set CloudPrintSubmitEnabled to false. Cloud print should no longer be available via built in print mechanisms Review URL: http://codereview.chromium.org/8395007 TBR=abodenha@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -48 lines) Patch
M chrome/app/policy/policy_templates.json View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_win_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Albert Bodenhamer
9 years, 1 month ago (2011-10-28 18:31:03 UTC) #1
Albert Bodenhamer
9 years, 1 month ago (2011-10-28 18:32:43 UTC) #2
On 2011/10/28 18:31:03, Albert Bodenhamer wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698