Issue 8416036: bookmarks: Rename ExtensionBookmarkManagerEventRouter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416036: bookmarks: Rename ExtensionBookmarkManagerEventRouter. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
Aaron Boodman, sky

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

bookmarks: Rename ExtensionBookmarkManagerEventRouter. Note: This was a TODO for aa@. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107945

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -26 lines)			Patch
M	chrome/browser/bookmarks/bookmark_manager_extension_api.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_manager_extension_api.cc	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

On 2011/10/28 18:29:39, sky wrote: > LGTM, but you need to also get aa to ...

9 years, 1 month ago (2011-10-29 00:15:43 UTC) #3

Aaron Boodman

9 years, 1 month ago (2011-10-29 18:39:52 UTC) #4

lgtm

Thiago, there are more of these kind of moves if you're interested in helping:
crbug.com/101244

Not all of them are obvious, but some are. For example:

extensions/extension_debugger_api* -> debugger/debugger_extension_api*
extensions/extension_devtools* -> debugger/devtools_extension*
extensions/extension_downloads* -> downloads/downloads_extension*

Expand Messages | Collapse Messages