Issue 8416033: Sync Promo: Correctly setup sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416033: Sync Promo: Correctly setup sync (Closed)

Created:
9 years, 1 month ago by sail

Modified:
9 years, 1 month ago

Reviewers:
James Hawkins, stevenjb, Andrew T Wilson (Slow)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Sync Promo: Correctly setup sync With r107251 the sync promo page stopped loading. The problem was due to a difference between the sync promo and the options Sign In UI. The options UI calls ShowSetupUI() when showing the sign in overlay. The promo wasn't calling this causing sync not to be setup correctly. Fix was to match the behavior of the options UI and call ShowSetupUI() when showing the sync promo page. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107757

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/sync_promo.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8416033/1

9 years, 1 month ago (2011-10-28 17:10:03 UTC) #4

Change committed as 107757

Expand Messages | Collapse Messages