Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8416029: Removing dedicated worker-related IPC code (second round). (Closed)

Created:
9 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removing dedicated worker-related IPC codei (second round). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107779

Patch Set 1 #

Patch Set 2 : Build fixed #

Total comments: 1

Patch Set 3 : Style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -617 lines) Patch
M content/browser/worker_host/worker_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +0 lines, -13 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/websharedworker_proxy.h View 1 2 4 chunks +53 lines, -3 lines 0 comments Download
M content/renderer/websharedworker_proxy.cc View 2 chunks +94 lines, -8 lines 0 comments Download
D content/renderer/webworker_base.h View 1 chunk +0 lines, -101 lines 0 comments Download
D content/renderer/webworker_base.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D content/renderer/webworker_proxy.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/renderer/webworker_proxy.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/tools/test_shell/test_web_worker.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webkit/tools/test_shell/test_web_worker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
second round of code cleanup
9 years, 1 month ago (2011-10-28 03:10:25 UTC) #1
jam
lgtm http://codereview.chromium.org/8416029/diff/19/content/renderer/websharedworker_proxy.h File content/renderer/websharedworker_proxy.h (right): http://codereview.chromium.org/8416029/diff/19/content/renderer/websharedworker_proxy.h#newcode48 content/renderer/websharedworker_proxy.h:48: private: nit: space
9 years, 1 month ago (2011-10-28 16:54:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dslomov@chromium.org/8416029/5001
9 years, 1 month ago (2011-10-28 19:02:53 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 20:09:42 UTC) #4 
Change committed as 107779

Powered by Google App Engine
This is Rietveld 408576698