Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 8416024: Re-land 107645 with static initializers removed. (Closed)

Created:
9 years, 1 month ago by kkania
Modified:
9 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, robertshield, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-land 107645 with static initializer removed. Don't inherit from content::RenderViewObserver, instead just create it on the fly when needed in tests. BUG=69370, 66371, 63022 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107792

Patch Set 1 : revert #

Patch Set 2 : remove static initializers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -216 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +27 lines, -68 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper.cc View 1 2 chunks +97 lines, -0 lines 0 comments Download
A chrome/renderer/automation/automation_renderer_helper_browsertest.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 4 chunks +14 lines, -105 lines 0 comments Download
D chrome/test/data/automation_proxy_snapshot/just_image.html View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kkania
patch 1 is just a revert of the revert #2 is the changes to remove ...
9 years, 1 month ago (2011-10-28 00:22:59 UTC) #1
Ryan Sleevi
I'm not qualified for anything more than a rubberstamp - as I don't know what ...
9 years, 1 month ago (2011-10-28 00:38:03 UTC) #2
kkania
jamesr: please review the few changes in the automation renderer. The previous CL was reverted ...
9 years, 1 month ago (2011-10-28 01:47:52 UTC) #3
jamesr
So the delta between patch set #1 and #2 is the delta between what originally ...
9 years, 1 month ago (2011-10-28 01:49:43 UTC) #4
kkania
On 2011/10/28 01:49:43, jamesr wrote: > So the delta between patch set #1 and #2 ...
9 years, 1 month ago (2011-10-28 01:52:08 UTC) #5
jamesr
OK, in that case lgtm
9 years, 1 month ago (2011-10-28 01:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/8416024/2003
9 years, 1 month ago (2011-10-28 19:39:53 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 21:09:08 UTC) #8
Change committed as 107792

Powered by Google App Engine
This is Rietveld 408576698