Issue 8416022: Revert 107645 (To see if it was responsible for increase in static initializers) - Fix test snaps...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416022: Revert 107645 (To see if it was responsible for increase in static initializers) - Fix test snaps... (Closed)

Created:
9 years, 1 month ago by eroman

Modified:
9 years, 1 month ago

Reviewers:
kkania

CC:
chromium-reviews, robertshield, darin-cc_chromium.org, brettw-cc_chromium.org, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 107645 (To see if it was responsible for increase in static initializers) - Fix test snapshotting on linux by creating a separate automation path for snapshots outside of the thumbnail generator. BUG=69370, 66371, 63022 TEST=none Review URL: http://codereview.chromium.org/8294030 TBR=kkania@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107647

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -290 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.h	View	2 chunks	+17 lines, -15 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View	1 chunk	+66 lines, -25 lines	0 comments	Download
M	chrome/browser/automation/automation_tab_helper.h	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/automation/automation_tab_helper.cc	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/automation_messages_internal.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/renderer/automation/automation_renderer_helper.h	View	1 chunk	+1 line, -16 lines	0 comments	Download
M	chrome/renderer/automation/automation_renderer_helper.cc	View	1 chunk	+1 line, -100 lines	0 comments	Download
D	chrome/renderer/automation/automation_renderer_helper_browsertest.cc	View	1 chunk	+0 lines, -78 lines	0 comments	Download
M	chrome/test/automation/automation_proxy_uitest.cc	View	4 chunks	+105 lines, -14 lines	0 comments	Download
A +	chrome/test/data/automation_proxy_snapshot/just_image.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/webdriver/test/chromedriver_tests.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM