Issue 8416018: Replace NewRunnableMethod with Callback in DownloadFileManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416018: Replace NewRunnableMethod with Callback in DownloadFileManager. (Closed)

Created:
9 years, 1 month ago by achuithb

Modified:
9 years, 1 month ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, achuith+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Replace NewRunnableMethod with Callback in DownloadFileManager. BUG=chromium-os:22024 TEST=compiles, tests pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107787

Patch Set 1 #

Patch Set 2 : lint errors #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -45 lines)			Patch
	M	content/browser/download/download_file_manager.cc	View	1	9 chunks	+32 lines, -45 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

Looks fine, but I'm curious about where the includes came from. http://codereview.chromium.org/8416018/diff/2001/content/browser/download/download_file_manager.cc File content/browser/download/download_file_manager.cc (right): ...

9 years, 1 month ago (2011-10-28 17:42:31 UTC) #2

achuithb

http://codereview.chromium.org/8416018/diff/2001/content/browser/download/download_file_manager.cc File content/browser/download/download_file_manager.cc (right): http://codereview.chromium.org/8416018/diff/2001/content/browser/download/download_file_manager.cc#newcode8 content/browser/download/download_file_manager.cc:8: #include <string> On 2011/10/28 17:42:31, rdsmith wrote: > Why ...

9 years, 1 month ago (2011-10-28 19:37:37 UTC) #3

lgtm

Expand Messages | Collapse Messages