tools/checkdeps/checkdeps.py - Issue 8416016: Fix checkdeps.py to check all the source directories in git checkouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/checkdeps/checkdeps.py

Issue 8416016: Fix checkdeps.py to check all the source directories in git checkouts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Simpler logic. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/checkdeps/checkdeps.py

diff --git a/tools/checkdeps/checkdeps.py b/tools/checkdeps/checkdeps.py

index b175beaf92cf209e92f59f6eeba322d33c56484a..e0ac354236cfedd5b67531deb2212f9bcaf59e4a 100755

--- a/tools/checkdeps/checkdeps.py

+++ b/tools/checkdeps/checkdeps.py

@@ -416,7 +416,9 @@ def GetGitSourceDirectory(root):

pipes.quote(root))

for line in popen_out.readlines():

dir_name = os.path.join(root, os.path.dirname(line))

- git_source_directory.add(dir_name)

+ while dir_name != root:

satorux1 2011/10/27 23:04:16 Would be nice to add some comment as the logic is

kinaba 2011/10/27 23:07:20 Done.

+ git_source_directory.add(dir_name)

+ dir_name = os.path.dirname(dir_name)

git_source_directory.add(root)

return git_source_directory

« no previous file with comments | « no previous file | no next file » | no next file with comments »