Issue 8416014: Force transition to FAST_ELEMENTS on out-of-bounds KeyedLoads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8416014: Force transition to FAST_ELEMENTS on out-of-bounds KeyedLoads. (Closed)

Created:
9 years, 1 month ago by danno

Modified:
9 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Force transition to FAST_ELEMENTS on out-of-bounds KeyedLoads. Proactively ensure that that objects don't get FAST_DOUBLE_ELEMENTS to reduce the number of double boxing operations when generated code calls the runtime frequently to satisfy KeyedLoad requests. Committed: http://code.google.com/p/v8/source/detail?r=9833

Patch Set 1 #

Patch Set 2 : Upload correct patch #

Patch Set 3 : Simplify patch #

Total comments: 1

Patch Set 4 : review feedback #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -68 lines)			Patch
	M	src/runtime.cc	View	1 2 3	3 chunks	+73 lines, -50 lines	0 comments	Download
	M	test/mjsunit/unbox-double-arrays.js	View	1 2	11 chunks	+37 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

9 years, 1 month ago (2011-10-28 08:44:54 UTC) #2

LGTM with a comment.

http://codereview.chromium.org/8416014/diff/3001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8416014/diff/3001/src/runtime.cc#newcode4265
src/runtime.cc:4265: }
I would merge "else { if [...] }" to "else if [...]" to save one level of
nesting.

Expand Messages | Collapse Messages