Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 8416003: Change internal name and visible name for settings to disable panels. (Closed)

Created:
9 years, 1 month ago by jennb
Modified:
9 years, 1 month ago
Reviewers:
dcheng
CC:
chromium-reviews
Visibility:
Public.

Description

Change internal name and visible name for settings to disable panels. BUG=None TEST=Look at about:flags and see 'Disable Panels'. Should be off by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jennb
Leaving the internal name unchanged caused conflict with previous setting - d'oh!
9 years, 1 month ago (2011-10-27 18:38:53 UTC) #1
jennb
Daniel, can you take this? Thanks.
9 years, 1 month ago (2011-10-27 18:58:51 UTC) #2
dcheng
9 years, 1 month ago (2011-10-27 19:00:00 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698