Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 8415004: Fix problem where app notification sync tests sometimes cant't delete temp dir (Closed)

Created:
9 years, 1 month ago by asargent_no_longer_on_chrome
Modified:
9 years, 1 month ago
Reviewers:
Munjal (Google)
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix problem where app notification sync tests sometimes cant't delete temp dir BUG=101963 TEST=Running unit_tests --gtest_filter=AppNotificationManagerSyncTest.* should not leave around any empty temp directories (and there should be no error log messages from ScopedTempDir's desctructor about being unable to delete the underlying temp dir). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/app_notification_manager_sync_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
9 years, 1 month ago (2011-10-27 20:01:56 UTC) #1
Munjal (Google)
LGTM. Good catch.
9 years, 1 month ago (2011-10-27 21:11:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8415004/1
9 years, 1 month ago (2011-10-27 21:12:42 UTC) #3
commit-bot: I haz the power
Try job failure for 8415004-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-10-27 21:59:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8415004/1
9 years, 1 month ago (2011-10-27 23:15:04 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 00:43:55 UTC) #6
Change committed as 107667

Powered by Google App Engine
This is Rietveld 408576698