Refactored TypedUrlChangeProcessor to treat ADD and UPDATE similarly.

Refactored TypedUrlChangeProcessor to treat ADD and UPDATE similarly.

Updated TypedUrlChangeProcessor to handle ADDs and UPDATEs in the sync DB identically.

Also removed our code that explicitly sets the title in the history DB as that
should not be necessary (it's already set by UpdateURLRow).

Finally, removed our code that was setting last_visit_time since that is also
updated automatically by the history code when we add/remove visits. We still
set it when we initially add the URL to the DB, but that's only because the
history code requires it - we technically don't need to since we always manually
add visits immediately afterward.

BUG=101633
TEST=existing tests suffice


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108188

[Andrew T Wilson (Slow), 2011-11-01 00:55:59]

Please take a look.

The core of this change is that TypedUrl UPDATE/ADD refactoring you pointed out
in your earlier review. While I was going through the code I noticed that we
were updating some fields (title, last_visit) when we didn't need to, so I've
changed the code to no longer manually update those fields (they are already
updated appropriately by the history code).

[Nicolas Zea, 2011-11-01 19:07:26]

lgtm

[commit-bot: I haz the power, 2011-11-01 21:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/8414043/3006

[commit-bot: I haz the power, 2011-11-01 23:07:32]

Change committed as 108188