Removed file access from UI thread for mobile config file loading.

Removed file access from UI thread for mobile config file loading.

BUG=chromium-os:11535
TEST=make sure no thread trelated assertion are happening during mobile activation now when ScopedAllowIO is removed 
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107970

[achuithb, 2011-10-29 01:42:44]

LGTM with optional nits.

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right):

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:176: void SetErrorMap(const
std::map<std::string, std::string>& map);
You could consider a typedef like
typedef std::map<std::string, std::string> ErrorMap;

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:376: LOG(INFO) << "Cellular
config file loaded: " << kCellularConfigPath;
Did you intend to land these log stmts or are these for debugging?

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:412:
error_map.insert(std::pair<std::string, std::string>(*keys, value));
with the ErrorMap typedef, this would become ErrorMap::value_type(*keys, value)

[zel, 2011-10-31 15:12:47]

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right):

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:176: void SetErrorMap(const
std::map<std::string, std::string>& map);
On 2011/10/29 01:42:44, achuith.bhandarkar wrote:
> You could consider a typedef like
> typedef std::map<std::string, std::string> ErrorMap;

Done.

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:376: LOG(INFO) << "Cellular
config file loaded: " << kCellularConfigPath;
On 2011/10/29 01:42:44, achuith.bhandarkar wrote:
> Did you intend to land these log stmts or are these for debugging?

Done.

http://codereview.chromium.org/8414039/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:412:
error_map.insert(std::pair<std::string, std::string>(*keys, value));
On 2011/10/29 01:42:44, achuith.bhandarkar wrote:
> with the ErrorMap typedef, this would become ErrorMap::value_type(*keys,
value)

Done.

[commit-bot: I haz the power, 2011-10-31 15:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8414039/4001

[commit-bot: I haz the power, 2011-10-31 15:14:54]

Try job failure for 8414039-4001 on linux_rel for steps "update_scripts,
update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-31 15:22:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8414039/9001

[commit-bot: I haz the power, 2011-10-31 15:22:44]

Try job failure for 8414039-9001 on linux_clang for steps "update_scripts,
update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.