Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 8414030: Relanding this as the earlier attempt broke chrome frame tests. (Closed)

Created:
9 years, 1 month ago by ananta
Modified:
9 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Relanding this as the earlier attempt broke chrome frame tests. Register the RenderViewHost instance created when a desktop notification bubble is displayed in CF with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through the host network stack implemenation. I also fixed a bug in the pending http jobs resumption code in the AutomationResourceMessagefilter which could cause a job to be registered in the old filter and the new filter for a while. Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251 BUG=64251 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107795

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -27 lines) Patch
M chrome/browser/automation/automation_resource_message_filter.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 3 chunks +32 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 1 month ago (2011-10-28 19:30:41 UTC) #1
robertshield
LGTM http://codereview.chromium.org/8414030/diff/1/chrome/browser/automation/automation_resource_message_filter.cc File chrome/browser/automation/automation_resource_message_filter.cc (right): http://codereview.chromium.org/8414030/diff/1/chrome/browser/automation/automation_resource_message_filter.cc#newcode268 chrome/browser/automation/automation_resource_message_filter.cc:268: // The tab handle may have changed in ...
9 years, 1 month ago (2011-10-28 19:54:23 UTC) #2
ananta
9 years, 1 month ago (2011-10-28 21:13:06 UTC) #3
http://codereview.chromium.org/8414030/diff/1/chrome/browser/automation/autom...
File chrome/browser/automation/automation_resource_message_filter.cc (right):

http://codereview.chromium.org/8414030/diff/1/chrome/browser/automation/autom...
chrome/browser/automation/automation_resource_message_filter.cc:268: // The tab
handle may have changed in the following scenario:-
On 2011/10/28 19:54:23, robertshield wrote:
> nit: remove the -

Done.

http://codereview.chromium.org/8414030/diff/1/chrome/browser/automation/autom...
chrome/browser/automation/automation_resource_message_filter.cc:276: // external
tab which is being destroyed
On 2011/10/28 19:54:23, robertshield wrote:
> Please clarify the last line of the comment. Does it mean that 
> automation_details_iter->second.tab_handle is the tab that is being destroyed?
> If so, consider
> "Replace the handle of the external tab being destroyed with the new one that
is
> being created."

Done.

Powered by Google App Engine
This is Rietveld 408576698