Issue 8414025: An additional defense in the Vorbis codec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8414025: An additional defense in the Vorbis codec. (Closed)

Created:
9 years, 1 month ago by Chris Evans

Modified:
9 years, 1 month ago

Reviewers:
rbultje1

CC:
chromium-reviews, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/

Visibility:
Public.

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -10 lines)			Patch
M	README.chromium	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	patches/README	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	patches/to_upstream/49_vorbis_buffer_defense.patch	View	1 chunk	+111 lines, -0 lines	0 comments	Download
M	source/patched-ffmpeg/libavcodec/vorbisdec.c	View	9 chunks	+25 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Chris Evans

An additional defense. Additional notes: - Its careful to do checks outside of the hot ...

9 years, 1 month ago (2011-10-28 16:34:34 UTC) #1

rbultje1

9 years, 1 month ago (2011-10-28 17:02:55 UTC) #2

LGTM.

Do you want me to take care of upstreaming all your vorbis patches, or will you
do it?