Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/test/webdriver/commands/command.h

Issue 8414020: Expose the sandbox related code through the content API. I did a bit of cleanup while I was doing... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/command.h
===================================================================
--- chrome/test/webdriver/commands/command.h (revision 107845)
+++ chrome/test/webdriver/commands/command.h (working copy)
@@ -11,7 +11,11 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
+#include "build/build_config.h"
+
+#if defined(OS_MACOX)
#include "base/mac/scoped_nsautorelease_pool.h"
+#endif
namespace webdriver {
@@ -101,12 +105,14 @@
const std::vector<std::string> path_segments_;
const scoped_ptr<const DictionaryValue> parameters_;
+#if defined(OS_MACOX)
// An autorelease pool must exist on any thread where Objective C is used,
// even implicitly. Otherwise the warning:
// "Objects autoreleased with no pool in place."
// is printed for every object deallocted. Since every incomming command to
// chrome driver is allocated a new thread, the release pool is declared here.
base::mac::ScopedNSAutoreleasePool autorelease_pool;
+#endif
DISALLOW_COPY_AND_ASSIGN(Command);
};

Powered by Google App Engine
This is Rietveld 408576698