gtk: fix more fullscreen bugs

gtk: fix more fullscreen bugs

1. hide/show titlebar widget when entering/exiting full screen
2. don't show bookmark bar when in fullscreen mode

BUG=97177
TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the new tab page. 4. You shouldn't see a line at the top.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107999

[Evan Stade, 2011-10-28 04:26:43]

please apply locally and test it out. I thought I had fixed this bug before but
I guess not. Would be good to get verification before and after this patch.

[Elliot Glaysher, 2011-10-28 17:43:47]

lgtm on xfce after patching this in locally. (was broken before)

On Thu, Oct 27, 2011 at 9:26 PM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> please apply locally and test it out. I thought I had fixed this bug before
> but
> I guess not. Would be good to get verification before and after this patch.
>
> Description:
> gtk: fix more fullscreen bugs
>
> 1. hide/show titlebar widget when entering/exiting full screen
> 2. don't show bookmark bar when in fullscreen mode
>
> BUG=97177
> TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the
> new
> tab page. 4. You shouldn't see a line at the top.
>
>
> Please review this at http://codereview.chromium.org/8414014/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
>  M chrome/browser/ui/gtk/browser_window_gtk.cc
>
>
> Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
> diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
> b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
> index
>
b9c15f2625411d0299022197b2c28e3cefff53a2..5e87b892bd2f968b2ce0c2230edfe69d915d410d
> 100644
> --- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
> +++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
> @@ -486,7 +486,8 @@ void BookmarkBarGtk::Hide(BookmarkBar::State old_state,
>
>   // After coming out of fullscreen, the browser window sets the bookmark
> bar
>   // to the "hidden" state, which means we need to show our minimum height.
> -  gtk_widget_show(widget());
> +  if (!window_->IsFullscreen())
> +    gtk_widget_show(widget());
>   CalculateMaxHeight();
>   // Sometimes we get called without a matching call to open. If that
> happens
>   // then force hide.
> Index: chrome/browser/ui/gtk/browser_window_gtk.cc
> diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc
> b/chrome/browser/ui/gtk/browser_window_gtk.cc
> index
>
fc7e9c9c0f5f9779e8bb716e700decbd1fa57140..e7f3bbbe376e72dbd834ee9c401e6e5bce3c56c1
> 100644
> --- a/chrome/browser/ui/gtk/browser_window_gtk.cc
> +++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
> @@ -1461,8 +1461,10 @@ gboolean BrowserWindowGtk::OnWindowState(GtkWidget*
> sender,
>             GURL(),
>             FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION));
>       }
> +      gtk_widget_hide(titlebar_widget());
>       gtk_widget_hide(toolbar_border_);
>     } else {
> +      gtk_widget_show(titlebar_widget());
>       fullscreen_exit_bubble_.reset();
>       UpdateCustomFrame();
>       ShowSupportedWindowFeatures();
>
>
>