Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Unified Diff: net/http/http_pipelined_connection_impl.h

Issue 8414010: Fix pipelining crash on canceled user callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_pipelined_connection_impl.h
diff --git a/net/http/http_pipelined_connection_impl.h b/net/http/http_pipelined_connection_impl.h
index bf39e625326ba7a6db3be3d3b3090daf2c7d7cf5..d77f9aeef75ce7b3d9d127249f7bf36d55766c8c 100644
--- a/net/http/http_pipelined_connection_impl.h
+++ b/net/http/http_pipelined_connection_impl.h
@@ -160,6 +160,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl
linked_ptr<HttpStreamParser> parser;
OldCompletionCallback* read_headers_callback;
+ OldCompletionCallback* pending_user_callback;
StreamState state;
};
@@ -235,7 +236,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl
// underlying parser completes SendRequest() or ReadResponseHeaders()
// synchronously, but we've already returned ERR_IO_PENDING to the user's
// SendRequest() or ReadResponseHeaders() call into us.
- void FireUserCallback(OldCompletionCallback* callback, int result);
+ void FireUserCallback(int pipeline_id, int result);
Delegate* delegate_;
scoped_ptr<ClientSocketHandle> connection_;
« no previous file with comments | « no previous file | net/http/http_pipelined_connection_impl.cc » ('j') | net/http/http_pipelined_connection_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698