Fix pipelining crash on canceled user callbacks.

net/http/http_pipelined_connection_impl_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_pipelined_connection_impl.h"
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 1007 matching lines @@
   EXPECT_EQ(OK,
             deleted_stream->SendRequest(headers, NULL, &response, &callback_));
 
   StreamDeleter deleter(deleted_stream);
   EXPECT_EQ(ERR_IO_PENDING,
             deleter_stream->ReadResponseHeaders(deleter.callback()));
   EXPECT_EQ(ERR_IO_PENDING, deleted_stream->ReadResponseHeaders(&callback_));
   data_->RunFor(1);
 }
 
+TEST_F(HttpPipelinedConnectionImplTest, CloseBeforeSendCallbackRuns) {
+  MockWrite writes[] = {
+    MockWrite(true, 0, "GET /close.html HTTP/1.1\r\n\r\n"),
+    MockWrite(true, 1, "GET /dummy.html HTTP/1.1\r\n\r\n"),
+  };
+  Initialize(NULL, 0, writes, arraysize(writes));
+
+  scoped_ptr<HttpStream> close_stream(NewTestStream("close.html"));
+  scoped_ptr<HttpStream> dummy_stream(NewTestStream("dummy.html"));
+
+  TestOldCompletionCallback close_callback;
+  HttpRequestHeaders headers;
+  HttpResponseInfo response;
+  EXPECT_EQ(ERR_IO_PENDING, close_stream->SendRequest(
+      headers, NULL, &response, &close_callback));
+
+  data_->RunFor(1);
+  EXPECT_FALSE(close_callback.have_result());
+
+  close_stream->Close(false);

[mmenke, 2011/10/28 00:54:09]

Add "MessageLoop::current()->RunAllPending();" to the end of both these tests to
make sure that if things fail, they fail in the body of the test.  While it's
run during shutdown anyways, it's easier to diagnose issues when they're
encountered in the body of a test.

+}
+
+TEST_F(HttpPipelinedConnectionImplTest, CloseBeforeReadCallbackRuns) {
+  MockWrite writes[] = {
+    MockWrite(false, 0, "GET /close.html HTTP/1.1\r\n\r\n"),
+    MockWrite(false, 3, "GET /dummy.html HTTP/1.1\r\n\r\n"),
+  };
+  MockRead reads[] = {
+    MockRead(false, 1, "HTTP/1.1 200 OK\r\n"),
+    MockRead(true, 2, "Content-Length: 7\r\n\r\n"),
+  };
+  Initialize(reads, arraysize(reads), writes, arraysize(writes));
+
+  scoped_ptr<HttpStream> close_stream(NewTestStream("close.html"));
+  scoped_ptr<HttpStream> dummy_stream(NewTestStream("dummy.html"));
+
+  HttpRequestHeaders headers;
+  HttpResponseInfo response;
+  EXPECT_EQ(OK,
+            close_stream->SendRequest(headers, NULL, &response, &callback_));
+
+  TestOldCompletionCallback close_callback;
+  EXPECT_EQ(ERR_IO_PENDING,
+            close_stream->ReadResponseHeaders(&close_callback));
+
+  data_->RunFor(1);
+  EXPECT_FALSE(close_callback.have_result());
+
+  close_stream->Close(false);
+}
+
 TEST_F(HttpPipelinedConnectionImplTest, OnPipelineHasCapacity) {
   MockWrite writes[] = {
     MockWrite(false, 0, "GET /ok.html HTTP/1.1\r\n\r\n"),
   };
   Initialize(NULL, 0, writes, arraysize(writes));
 
   EXPECT_CALL(delegate_, OnPipelineHasCapacity(pipeline_.get())).Times(0);
   scoped_ptr<HttpStream> stream(NewTestStream("ok.html"));
 
   EXPECT_CALL(delegate_, OnPipelineHasCapacity(pipeline_.get())).Times(1);
@@ skipping 20 matching lines @@
 
   EXPECT_CALL(delegate_, OnPipelineHasCapacity(pipeline_.get())).Times(1);
   MessageLoop::current()->RunAllPending();
 
   stream->Close(false);
   EXPECT_CALL(delegate_, OnPipelineHasCapacity(pipeline_.get())).Times(1);
   stream.reset(NULL);
 }
 
 }  // namespace net