content/browser/download/mock_download_manager_delegate.cc - Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/mock_download_manager_delegate.cc

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tweaked comment. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_manager.cc ('K') | « content/browser/download/mock_download_manager_delegate.h ('k') | content/public/browser/download_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/mock_download_manager_delegate.cc

diff --git a/content/browser/download/mock_download_manager_delegate.cc b/content/browser/download/mock_download_manager_delegate.cc

index e5b8b66ca9761c9564017fecbcf770ab9c30f649..e5d510408064f0268b866a6ce47a66ce4f308a90 100644

--- a/content/browser/download/mock_download_manager_delegate.cc

+++ b/content/browser/download/mock_download_manager_delegate.cc

@@ -36,11 +36,11 @@ bool MockDownloadManagerDelegate::ShouldOpenFileBasedOnExtension(

return false;

}

-bool MockDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {

+bool MockDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {

return true;

}

-bool MockDownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {

+bool MockDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {

return true;

}