chrome/browser/download/chrome_download_manager_delegate.h - Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tweaked comment. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/chrome_download_manager_delegate.h

diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h

index 0f87fa2261a5542e99dd7ed85572b99a7b9b50e5..68f987a61065334fa4bbd3e9e8a36f9ea3c3d8f0 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.h

+++ b/chrome/browser/download/chrome_download_manager_delegate.h

@@ -58,8 +58,8 @@ class ChromeDownloadManagerDelegate

FilePath* intermediate_path) OVERRIDE;

virtual TabContents* GetAlternativeTabContentsToNotifyForDownload() OVERRIDE;

virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;

- virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE;

virtual bool ShouldCompleteDownload(DownloadItem* item) OVERRIDE;

+ virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE;

virtual bool GenerateFileHash() OVERRIDE;

virtual void OnResponseCompleted(DownloadItem* item,

const std::string& hash) OVERRIDE;

« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | content/browser/download/download_manager.cc » ('J')