Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: content/shell/shell_download_manager_delegate.h

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged to TOT. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_ 5 #ifndef CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_
6 #define CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_ 6 #define CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 14 matching lines...) Expand all
25 25
26 virtual void Shutdown() OVERRIDE; 26 virtual void Shutdown() OVERRIDE;
27 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE; 27 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE;
28 virtual void ChooseDownloadPath(TabContents* tab_contents, 28 virtual void ChooseDownloadPath(TabContents* tab_contents,
29 const FilePath& suggested_path, 29 const FilePath& suggested_path,
30 void* data) OVERRIDE; 30 void* data) OVERRIDE;
31 virtual bool OverrideIntermediatePath(DownloadItem* item, 31 virtual bool OverrideIntermediatePath(DownloadItem* item,
32 FilePath* intermediate_path) OVERRIDE; 32 FilePath* intermediate_path) OVERRIDE;
33 virtual TabContents* GetAlternativeTabContentsToNotifyForDownload() OVERRIDE; 33 virtual TabContents* GetAlternativeTabContentsToNotifyForDownload() OVERRIDE;
34 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE; 34 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;
35 virtual bool ShouldCompleteDownload(DownloadItem* item) OVERRIDE;
35 virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE; 36 virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE;
36 virtual bool ShouldCompleteDownload(DownloadItem* item) OVERRIDE;
37 virtual bool GenerateFileHash() OVERRIDE; 37 virtual bool GenerateFileHash() OVERRIDE;
38 virtual void OnResponseCompleted(DownloadItem* item, 38 virtual void OnResponseCompleted(DownloadItem* item,
39 const std::string& hash) OVERRIDE; 39 const std::string& hash) OVERRIDE;
40 virtual void AddItemToPersistentStore(DownloadItem* item) OVERRIDE; 40 virtual void AddItemToPersistentStore(DownloadItem* item) OVERRIDE;
41 virtual void UpdateItemInPersistentStore(DownloadItem* item) OVERRIDE; 41 virtual void UpdateItemInPersistentStore(DownloadItem* item) OVERRIDE;
42 virtual void UpdatePathForItemInPersistentStore( 42 virtual void UpdatePathForItemInPersistentStore(
43 DownloadItem* item, 43 DownloadItem* item,
44 const FilePath& new_path) OVERRIDE; 44 const FilePath& new_path) OVERRIDE;
45 virtual void RemoveItemFromPersistentStore(DownloadItem* item) OVERRIDE; 45 virtual void RemoveItemFromPersistentStore(DownloadItem* item) OVERRIDE;
46 virtual void RemoveItemsFromPersistentStoreBetween( 46 virtual void RemoveItemsFromPersistentStoreBetween(
(...skipping 19 matching lines...) Expand all
66 DownloadStateInfo state); 66 DownloadStateInfo state);
67 67
68 DownloadManager* download_manager_; 68 DownloadManager* download_manager_;
69 69
70 DISALLOW_COPY_AND_ASSIGN(ShellDownloadManagerDelegate); 70 DISALLOW_COPY_AND_ASSIGN(ShellDownloadManagerDelegate);
71 }; 71 };
72 72
73 } // namespace content 73 } // namespace content
74 74
75 #endif // CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_ 75 #endif // CONTENT_SHELL_SHELL_DOWNLOAD_MANAGER_DELEGATE_H_
OLDNEW
« no previous file with comments | « content/public/browser/download_manager_delegate.h ('k') | content/shell/shell_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698