Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 8414007: Rearrange Should*Download delegate calls to be more useful and intuitive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged to TOT. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/hash_tables.h" 10 #include "base/hash_tables.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 virtual void Shutdown() OVERRIDE; 53 virtual void Shutdown() OVERRIDE;
54 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE; 54 virtual bool ShouldStartDownload(int32 download_id) OVERRIDE;
55 virtual void ChooseDownloadPath(TabContents* tab_contents, 55 virtual void ChooseDownloadPath(TabContents* tab_contents,
56 const FilePath& suggested_path, 56 const FilePath& suggested_path,
57 void* data) OVERRIDE; 57 void* data) OVERRIDE;
58 virtual bool OverrideIntermediatePath(DownloadItem* item, 58 virtual bool OverrideIntermediatePath(DownloadItem* item,
59 FilePath* intermediate_path) OVERRIDE; 59 FilePath* intermediate_path) OVERRIDE;
60 virtual TabContents* GetAlternativeTabContentsToNotifyForDownload() OVERRIDE; 60 virtual TabContents* GetAlternativeTabContentsToNotifyForDownload() OVERRIDE;
61 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE; 61 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;
62 virtual bool ShouldCompleteDownload(DownloadItem* item) OVERRIDE;
62 virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE; 63 virtual bool ShouldOpenDownload(DownloadItem* item) OVERRIDE;
63 virtual bool ShouldCompleteDownload(DownloadItem* item) OVERRIDE;
64 virtual bool GenerateFileHash() OVERRIDE; 64 virtual bool GenerateFileHash() OVERRIDE;
65 virtual void OnResponseCompleted(DownloadItem* item, 65 virtual void OnResponseCompleted(DownloadItem* item,
66 const std::string& hash) OVERRIDE; 66 const std::string& hash) OVERRIDE;
67 virtual void AddItemToPersistentStore(DownloadItem* item) OVERRIDE; 67 virtual void AddItemToPersistentStore(DownloadItem* item) OVERRIDE;
68 virtual void UpdateItemInPersistentStore(DownloadItem* item) OVERRIDE; 68 virtual void UpdateItemInPersistentStore(DownloadItem* item) OVERRIDE;
69 virtual void UpdatePathForItemInPersistentStore( 69 virtual void UpdatePathForItemInPersistentStore(
70 DownloadItem* item, 70 DownloadItem* item,
71 const FilePath& new_path) OVERRIDE; 71 const FilePath& new_path) OVERRIDE;
72 virtual void RemoveItemFromPersistentStore(DownloadItem* item) OVERRIDE; 72 virtual void RemoveItemFromPersistentStore(DownloadItem* item) OVERRIDE;
73 virtual void RemoveItemsFromPersistentStoreBetween( 73 virtual void RemoveItemsFromPersistentStoreBetween(
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 // Maps from pending extension installations to DownloadItem IDs. 147 // Maps from pending extension installations to DownloadItem IDs.
148 typedef base::hash_map<CrxInstaller*, int> CrxInstallerMap; 148 typedef base::hash_map<CrxInstaller*, int> CrxInstallerMap;
149 CrxInstallerMap crx_installers_; 149 CrxInstallerMap crx_installers_;
150 150
151 content::NotificationRegistrar registrar_; 151 content::NotificationRegistrar registrar_;
152 152
153 DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate); 153 DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate);
154 }; 154 };
155 155
156 #endif // CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_ 156 #endif // CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698