Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 8414006: Make FileManagerDialog::SelectFileImpl() properly accept simple filenames as default path. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
Reviewers:
rginda
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Make FileManagerDialog::SelectFileImpl() properly accept simple filenames as default path. This affects Chrome OS. 1 - If the default path provided isn't managed by the external filesystem provider, still keep the base (i.e., file) name. 2 - Fix the JS regex so that it splits the directory/leaf names correctly when no path is provided. BUG=http://code.google.com/p/chromium-os/issues/detail?id=22184 TEST=The main test is that sufficiently-recent Pepper Flash should provide correct (Flash) Save As functionality, including the default filename; e.g., http://www.everythingflex.com/flex3_fp10/savetodisk/SaveToDisk.html . Also, "Save As" for HTML should also provide a default filename on Linux chromeos=1 builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/file_manager_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years, 1 month ago (2011-10-27 22:02:36 UTC) #1
rginda
On 2011/10/27 22:02:36, viettrungluu wrote: LGTM, thanks for the fix!
9 years, 1 month ago (2011-10-27 23:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8414006/1
9 years, 1 month ago (2011-10-31 19:41:31 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 20:47:04 UTC) #4
Change committed as 108009

Powered by Google App Engine
This is Rietveld 408576698