Issue 8414005: Register the RenderViewHost instance created when a desktop notification bubble is displayed in CF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8414005: Register the RenderViewHost instance created when a desktop notification bubble is displayed in CF (Closed)

Created:
9 years, 1 month ago by ananta

Modified:
9 years, 1 month ago

Reviewers:
robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Register the RenderViewHost instance created when a desktop notification bubble is displayed in CF with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through the host network stack implemenation. Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251 BUG=64251 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107669

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/browser/external_tab_container_win.cc	View		3 chunks	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertshield

9 years, 1 month ago (2011-10-28 00:59:38 UTC) #2

LGTM, just whitespace nits

http://codereview.chromium.org/8414005/diff/1/chrome/browser/external_tab_con...
File chrome/browser/external_tab_container_win.cc (right):

http://codereview.chromium.org/8414005/diff/1/chrome/browser/external_tab_con...
chrome/browser/external_tab_container_win.cc:869: }
nit: could you fix the incorrect indentation for the above two case blocks?

http://codereview.chromium.org/8414005/diff/1/chrome/browser/external_tab_con...
chrome/browser/external_tab_container_win.cc:886: 
nit: remove blank  here and the blank line above and below the new case block as
well

Expand Messages | Collapse Messages