Issue 8414004: GTK: Constrain the clip area on tabstrip draws.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8414004: GTK: Constrain the clip area on tabstrip draws. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 1 month ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

GTK: Constrain the clip area on tabstrip draws. Only redraw the entire tabstrip if we're animating or are dragging a tab. Otherwise we can fast path and only draw all the tabs to the left of the dirty rectangle and still get the correct stacking behaviour. BUG=100803 TEST=all tab functionality should work without artifacts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107798

Patch Set 1 #

Patch Set 2 : Add comment for estade #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
	M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc	View	1	1 chunk	+26 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8414004/3

9 years, 1 month ago (2011-10-28 20:25:10 UTC) #3

Change committed as 107798

Expand Messages | Collapse Messages