Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 8414002: Update chromium tests for new IDBDatabase.transaction() restrictions. (Closed)

Created:
9 years, 1 month ago by jsbell
Modified:
9 years, 1 month ago
Reviewers:
dgrogan, yurys
CC:
chromium-reviews, Paweł Hajdan Jr., dgrogan, hans
Visibility:
Public.

Description

Update chromium tests for new IDBDatabase.transaction() restrictions. The transaction([]) shortcut is no longer supported, stores must be listed explicitly. WebKit change is https://bugs.webkit.org/show_bug.cgi?id=70251 Discussion of change: https://groups.google.com/a/chromium.org/group/chromium-html5/browse_thread/thread/f667458ca6455d33/1496ad2d1a67b53f#1496ad2d1a67b53f BUG=101927 TEST=content_unittests --gtest_filter='*IndexedDB*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107617

Patch Set 1 #

Patch Set 2 : Re-enables the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/test/data/indexeddb/quota_test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/indexeddb/transaction_run_forever.js View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/indexeddb/transaction_test.js View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dgrogan
9 years, 1 month ago (2011-10-27 18:45:21 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698