Issue 8413073: MIPS: updated atomic operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8413073: MIPS: updated atomic operations. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, Kevin Millikin (Chromium), danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: updated atomic operations. Specifically: -fixed a bug in CompareAndSwap that caused randomly occuring timeouts on MIPS boards. -added gcc inline asm control push/pop instructions to correctly save/restore the reorder setting instead of simply assuming it should be enabled. -reordered/optimized some instructions to utilize MIPS-specific pipelining features (branch delay slot). -fixed improper usage of write barriers BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9845

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -18 lines)			Patch
	M	src/atomicops_internals_mips_gcc.h	View		7 chunks	+30 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 1 month ago (2011-10-31 12:47:17 UTC) #2

Thanks for the patch.  This LGTM, I will land it.

Expand Messages | Collapse Messages