Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8413070: Revert Valgrind binaries to r112 (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert Valgrind binaries to r112 TBR=glider TEST=Mac/Valgrind turns green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -184 lines) Patch
M binaries/linux_x64/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-amd64-linux View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/mac/bin/ms_print View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/bin/valgrind View Binary file 0 comments Download
M binaries/mac/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac/lib/valgrind/default.supp View 2 chunks +71 lines, -4 lines 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/bin/ms_print View 1 chunk +1 line, -1 line 0 comments Download
M binaries/mac_10.6/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind View Binary file 0 comments Download
M binaries/mac_10.6/bin/valgrind-listener View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/default.supp View 4 chunks +72 lines, -169 lines 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so View Binary file 0 comments Download
M scripts/build-memcheck-for-chromium.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Timur Iskhodzhanov
9 years, 1 month ago (2011-10-29 17:50:45 UTC) #1
Alexander Potapenko
LGTM Please change the valgrind-variant revision in the README file. Also note that Mac revision ...
9 years, 1 month ago (2011-10-29 18:16:39 UTC) #2
Alexander Potapenko
9 years, 1 month ago (2011-10-29 18:18:03 UTC) #3 
>Please change the valgrind-variant revision in the README file.
... when landing new binaries.
> Also note that Mac revision was not r112, so the problems may have been caused
The previous Mac revision.

Powered by Google App Engine
This is Rietveld 408576698