Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: base/debug/trace_event.h

Issue 8413063: Revert 107813 - add classes trace_analyzer::Query and TraceAnalyzer to make it easy to search thr... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | base/debug/trace_event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event.h
===================================================================
--- base/debug/trace_event.h (revision 107844)
+++ base/debug/trace_event.h (working copy)
@@ -102,7 +102,6 @@
#include "base/callback.h"
#include "base/hash_tables.h"
-#include "base/memory/ref_counted_memory.h"
#include "base/memory/singleton.h"
#include "base/string_util.h"
#include "base/third_party/dynamic_annotations/dynamic_annotations.h"
@@ -420,10 +419,6 @@
return value;
}
- bool is_string() const {
- return type_ == TRACE_TYPE_STRING || type_ == TRACE_TYPE_STATIC_STRING;
- }
-
void AppendAsJSON(std::string* out) const;
Type type() const {
@@ -450,7 +445,7 @@
return value_.as_pointer;
}
const char* as_string() const {
- DCHECK(is_string());
+ DCHECK(type_ == TRACE_TYPE_STRING || type_ == TRACE_TYPE_STATIC_STRING);
return value_.as_string;
}
const char** as_assignable_string() {
@@ -476,7 +471,7 @@
// OutputCallback whenever the tracing system decides to flush. This
// can happen at any time, on any thread, or you can programatically
// force it to happen.
-class BASE_EXPORT TraceEvent {
+class TraceEvent {
public:
TraceEvent();
TraceEvent(unsigned long process_id,
@@ -490,9 +485,6 @@
bool copy);
~TraceEvent();
- static const char* GetPhaseString(TraceEventPhase phase);
- static TraceEventPhase GetPhase(const char* phase);
-
// Serialize event data to JSON
static void AppendEventsAsJSON(const std::vector<TraceEvent>& events,
size_t start,
« no previous file with comments | « base/base.gyp ('k') | base/debug/trace_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698