Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 8413059: Roll libjingle 88:92 (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 1 month ago
CC:
chromium-reviews, GeorgeY, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, jamiewalch+watch_chromium.org, lambroslambrou+watch_chromium.org, dyu1, ajwong+watch_chromium.org, sergeyu+watch_chromium.org, Ilya Sherman, dhollowa
Visibility:
Public.

Description

Roll libjingle 88:92 Beside other changes the new version of libjingle has thread-safe QName class and has all std::string and QName statics removed. BUG=94993, 102451 TEST=Compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108065

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : s/90/91/ #

Patch Set 4 : - #

Patch Set 5 : - #

Patch Set 6 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -127 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_xml_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 6 chunks +20 lines, -18 lines 0 comments Download
D third_party/libjingle/overrides/talk/xmllite/qname.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/libjingle/overrides/talk/xmllite/qname.cc View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
9 years, 1 month ago (2011-10-28 23:39:23 UTC) #1
akalin
LGTM
9 years, 1 month ago (2011-10-28 23:43:50 UTC) #2
akalin
On 2011/10/28 23:43:50, akalin wrote: > LGTM Although it would be nice if you could ...
9 years, 1 month ago (2011-10-28 23:44:08 UTC) #3
Sergey Ulanov
On 2011/10/28 23:44:08, akalin wrote: > On 2011/10/28 23:43:50, akalin wrote: > > LGTM > ...
9 years, 1 month ago (2011-10-28 23:45:37 UTC) #4
Sergey Ulanov
Ronghua, I've just disabled compilation of mediaengine.cc and webrtcvideoengine.cc. We can reenable them later after ...
9 years, 1 month ago (2011-11-01 00:19:36 UTC) #5
Ronghua Wu (Left Chromium)
Ok, we can re-enable them later after I fix the devicemanager. On Mon, Oct 31, ...
9 years, 1 month ago (2011-11-01 00:21:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8413059/13011
9 years, 1 month ago (2011-11-01 01:13:06 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 02:44:34 UTC) #8
Change committed as 108065

Powered by Google App Engine
This is Rietveld 408576698