Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8413052: Cleanup: Change a static initializer to a LazyInstance, and add some typedefs. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Cleanup: Change a static initializer to a LazyInstance, and add some typedefs. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107824

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M base/mime_util_xdg.cc View 11 chunks +30 lines, -25 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-10-28 21:24:33 UTC) #1
willchan no longer on Chromium
LGTM http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc File base/mime_util_xdg.cc (right): http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc#newcode32 base/mime_util_xdg.cc:32: static base::LazyInstance<base::Lock> I wonder if you should use ...
9 years, 1 month ago (2011-10-28 21:42:24 UTC) #2
Lei Zhang
http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc File base/mime_util_xdg.cc (right): http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc#newcode32 base/mime_util_xdg.cc:32: static base::LazyInstance<base::Lock> On 2011/10/28 21:42:25, willchan wrote: > I ...
9 years, 1 month ago (2011-10-28 21:54:02 UTC) #3
willchan no longer on Chromium
9 years, 1 month ago (2011-10-31 18:56:44 UTC) #4
On 2011/10/28 21:54:02, Lei Zhang wrote:
> http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc
> File base/mime_util_xdg.cc (right):
> 
> http://codereview.chromium.org/8413052/diff/1/base/mime_util_xdg.cc#newcode32
> base/mime_util_xdg.cc:32: static base::LazyInstance<base::Lock>
> On 2011/10/28 21:42:25, willchan wrote:
> > I wonder if you should use LeakyLazyInstance. Not sure if we need to delete
> this
> > guy.
> 
> Would you say that's true of all locks? There's 7 our
> base::LazyInstance<base::Lock> instantiations. We can change them all in a
> separate CL.

Yes, I think it's true of all locks.

Powered by Google App Engine
This is Rietveld 408576698