Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8413051: Move PageZoom enum into content/public/common and into the content namespace. Also move content_c... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, kkania, amit, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, robertshield
Visibility:
Public.

Description

Move PageZoom enum into content/public/common and into the content namespace. Also move content_costants to content/public/common. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107804

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -186 lines) Patch
M chrome/browser/automation/automation_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/default_plugin/plugin_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/default_plugin/plugin_impl_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/default_plugin/plugin_installer_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/cfproxy_private.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/external_tab.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/external_tab.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/external_tab_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/content_constants.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/common/content_constants.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D content/common/page_zoom.h View 1 chunk +0 lines, -25 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/common_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/common/content_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/common/content_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/common/page_zoom.h View 1 chunk +12 lines, -14 lines 0 comments Download
M content/public/common/webkit_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-10-28 20:54:41 UTC) #1
Avi (use Gerrit)
9 years, 1 month ago (2011-10-28 20:58:06 UTC) #2 
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698