Issue 8413050: Fix selection related crash in debug build.

Issue 8413050: Fix selection related crash in debug build. (Closed)

Created:
9 years, 1 month ago by Peng

Modified:
9 years, 1 month ago

Reviewers:
James Su, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Elliot Glaysher, Joao da Silva, bryeung

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix selection related crash in debug build. BUG=chromium:101435 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107838

Patch Set 1 : update #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/renderer/render_view_impl.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Peng

On 2011/10/28 19:41:27, Peng wrote: Sorry! I found the mistake. Please stop review it.

9 years, 1 month ago (2011-10-28 19:49:07 UTC) #2

Peng

On 2011/10/28 19:49:07, Peng wrote: > On 2011/10/28 19:41:27, Peng wrote: > > Sorry! I ...

9 years, 1 month ago (2011-10-28 20:03:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/8413050/5001

9 years, 1 month ago (2011-10-28 20:40:30 UTC) #5

James Su

http://codereview.chromium.org/8413050/diff/5001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8413050/diff/5001/content/renderer/render_view_impl.cc#newcode3270 content/renderer/render_view_impl.cc:3270: range.set_end(range.start() + text.length()); I'm wondering in which case they ...

9 years, 1 month ago (2011-10-28 22:05:26 UTC) #6

commit-bot: I haz the power

List of reviewers changed. suzhe@chromium.org did a drive-by without LGTM'ing!

9 years, 1 month ago (2011-10-28 22:30:13 UTC) #7

Peng

On 2011/10/28 22:05:26, James Su wrote: > http://codereview.chromium.org/8413050/diff/5001/content/renderer/render_view_impl.cc > File content/renderer/render_view_impl.cc (right): > > http://codereview.chromium.org/8413050/diff/5001/content/renderer/render_view_impl.cc#newcode3270 ...

9 years, 1 month ago (2011-10-28 22:42:44 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/8413050/5001

9 years, 1 month ago (2011-10-28 22:42:57 UTC) #10

Change committed as 107838

Expand Messages | Collapse Messages