Issue 8413038: Temporarily disabling the "applies to" column in about:policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8413038: Temporarily disabling the "applies to" column in about:policy. (Closed)

Created:
9 years, 1 month ago by Joao da Silva

Modified:
9 years, 1 month ago

Reviewers:
James Hawkins, Mattias Nissler (ping if slow)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Temporarily disabling the "applies to" column in about:policy. BUG=102114 TEST=about:policy doesn't show the "Applies To" column. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107781

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/resources/policy.html	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM, you need to get OWNERS approval though.

9 years, 1 month ago (2011-10-28 15:33:43 UTC) #2

Joao da Silva

Adding @jhawkins for owner review. @jhawkins: this column won't display anything meaningful for a while, ...

9 years, 1 month ago (2011-10-28 15:41:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8413038/1

9 years, 1 month ago (2011-10-28 20:12:19 UTC) #5

commit-bot: I haz the power

9 years, 1 month ago (2011-10-28 20:12:20 UTC) #6

Can't apply patch for file chrome/browser/resources/policy.html.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/policy.html
Hunk #1 FAILED at 106.
Hunk #2 FAILED at 116.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/resources/policy.html.rej

Expand Messages | Collapse Messages